Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whiskey Outpost for burrower add the ability to make tunnel but remove the ability to burrow. #6283

Merged
merged 6 commits into from
Jun 3, 2024

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented May 13, 2024

About the pull request

A-Remove the ability for the burrower to burrower.
B-Add the ability for the burrower to make tunnels.
C-added some more C4 to the marine weapon vendor.
D-updating the clothing vendors
1-remove telephone.
2-updating the vendor to what is in main mode.
3-keep headsets.

Explain why it's good for the game

A,B,C the idea is to allow burrower to speed up movement on conquered ground.(having to restart from the bottom of the map every-time is a pain for xenos.
the extra C4 is allow engi to deal with the ability of making tunnel.
D the idea is to update the vendor so that it as all the items that have some usage in WO.

burrowing would be too powerful with this ability so i am removing it.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
balance: for burrower in whiskey outpost add the ability to make tunnel but remove the ability to burrow.
balance: add C4 to the wo weapon vendor.
balance: updating the clothing surplus vendor on to be as close as main mode as possible.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label May 13, 2024
@Huffie56 Huffie56 marked this pull request as ready for review May 13, 2024 15:03
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not very keen on this change; but regardless if you wanted to do this, then you must increase access to plastic explosives for WO vendors.

@Drulikar Drulikar marked this pull request as draft May 14, 2024 08:04
@ihatethisengine
Copy link
Contributor

I think this change is good. Tunnels will make it easier to travel on WO, and without burrowing you won't have cheese tunnels in your rear.

Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label May 22, 2024
@Huffie56 Huffie56 marked this pull request as ready for review May 26, 2024 16:01
@Huffie56
Copy link
Contributor Author

should be fine i left drop pouch as it as it's use outside of dropping with a DS with it.
decided to group all the change on a single PR to avoid merge conflicts.
hope it's not to bad it's been a while since i touch code.

@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label May 28, 2024
@Drulikar Drulikar added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jun 3, 2024
@Drulikar Drulikar added this pull request to the merge queue Jun 3, 2024
Merged via the queue into cmss13-devs:master with commit ba28f5c Jun 3, 2024
29 checks passed
cm13-github added a commit that referenced this pull request Jun 3, 2024
@Huffie56 Huffie56 deleted the burrowerwo branch June 5, 2024 14:47
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
…e the ability to burrow. (cmss13-devs#6283)

# About the pull request
A-Remove the ability for the burrower to burrower.
B-Add the ability for the burrower to make tunnels.
C-added some more C4 to the marine weapon vendor.
D-updating the clothing vendors
1-remove telephone.
2-updating the vendor to what is in main mode.
3-keep headsets.
<!-- Remove this text and explain what the purpose of your PR is.

Mention if you have tested your changes. If you changed a map, make sure
you used the mapmerge tool.
If this is an Issue Correction, you can type "Fixes Issue #169420" to
link the PR to the corresponding Issue number #169420.

Remember: something that is self-evident to you might not be to others.
Explain your rationale fully, even if you feel it goes without saying.
-->

# Explain why it's good for the game
A,B,C the idea is to allow burrower to speed up movement on conquered
ground.(having to restart from the bottom of the map every-time is a
pain for xenos.
the extra C4 is allow engi to deal with the ability of making tunnel.
D the idea is to update the vendor so that it as all the items that have
some usage in WO.

burrowing would be too powerful with this ability so i am removing it.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>


# Changelog
:cl:
balance: for burrower in whiskey outpost add the ability to make tunnel
but remove the ability to burrow.
balance: add C4 to the wo weapon vendor.
balance: updating the clothing surplus vendor on to be as close as main
mode as possible.
/:cl:

---------

Co-authored-by: Julien <[email protected]>
Git-Nivrak pushed a commit to Git-Nivrak/cmss13 that referenced this pull request Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants